smaheshwar-pltr commented on code in PR #13225:
URL: https://github.com/apache/iceberg/pull/13225#discussion_r2505900224
##########
core/src/main/java/org/apache/iceberg/rest/RESTTableOperations.java:
##########
@@ -115,14 +146,25 @@ public void commit(TableMetadata base, TableMetadata
metadata) {
Consumer<ErrorResponse> errorHandler;
List<UpdateRequirement> requirements;
List<MetadataUpdate> updates;
+
+ TableMetadata metadataToCommit = metadata;
+ if (encryption() instanceof StandardEncryptionManager) {
Review Comment:
Thanks for pointing this out, makes sense 🙏
I've mirrored the
[`HiveTableOperations`](https://github.com/apache/iceberg/blob/main/hive-metastore/src/main/java/org/apache/iceberg/hive/HiveTableOperations.java)
in this PR (I will try to reduce the duplication).
@ggershinsky I think this review comment along with others apply to the Hive
side too that the REST-side should ideally have consistency with, WDYT here?
Maybe makes sense to patch for Hive if relevant then I can rebase and reflect?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
