smaheshwar-pltr commented on code in PR #13225:
URL: https://github.com/apache/iceberg/pull/13225#discussion_r2593734150
##########
core/src/main/java/org/apache/iceberg/rest/RESTTableOperations.java:
##########
@@ -57,27 +67,51 @@ enum UpdateType {
private final String path;
private final Supplier<Map<String, String>> headers;
private final FileIO io;
+ private final KeyManagementClient kmsClient;
private final List<MetadataUpdate> createChanges;
private final TableMetadata replaceBase;
private final Set<Endpoint> endpoints;
private UpdateType updateType;
private TableMetadata current;
+ private EncryptionManager encryptionManager;
+ private EncryptingFileIO encryptingFileIO;
+ private String tableKeyId;
+ private int encryptionDekLength;
+
+ // keys loaded from the latest metadata
+ private Optional<List<EncryptedKey>> encryptedKeysFromMetadata =
Optional.empty();
+
+ // keys added to EM (e.g. as a result of a FileAppend) but not committed
into the latest metadata
+ // yet
+ private Optional<List<EncryptedKey>> encryptedKeysPending = Optional.empty();
Review Comment:
(I've now added those changes into this PR)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
