jamespfaulkner commented on code in PR #14401:
URL: https://github.com/apache/iceberg/pull/14401#discussion_r2495492149


##########
core/src/main/java/org/apache/iceberg/data/avro/DataReader.java:
##########
@@ -146,6 +146,12 @@ public ValueReader<?> primitive(Type.PrimitiveType 
ignored, Schema primitive) {
             }
             return GenericReaders.timestampNanos();
 
+          case "timestamp-millis":

Review Comment:
   Added the same tests we had for PlannedDataReader. Also added tests for the 
TZ code path too.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to