nastra commented on code in PR #14401:
URL: https://github.com/apache/iceberg/pull/14401#discussion_r2494028380
##########
core/src/main/java/org/apache/iceberg/data/avro/DataWriter.java:
##########
@@ -130,6 +130,12 @@ public ValueWriter<?> primitive(Schema primitive) {
}
return GenericWriters.timestampNanos();
+ case "timestamp-millis":
Review Comment:
yes indeed we should be removing "timestamp-millis" from the writers. Adding
the possibility to read timestamp millis is fine, but we don't want to write it
from Iceberg
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
