jamespfaulkner opened a new pull request, #14401: URL: https://github.com/apache/iceberg/pull/14401
Hey folks, This PR addresses the issue https://github.com/apache/iceberg/issues/12395 I've contributed a slightly modified version of the original [PR](https://github.com/apache/iceberg/pull/12397/files) addressing this issue. The differences are: * This includes changes to `PlannedDataReader` to account for the deprecation of `DataReader` * `timestamp-millis` is handled independently of `timestamp-micros` to account for data files written outside of iceberg. I tested this locally on a small avro based hive table that was migrated to iceberg and queried via a `IcebergGenerics:read` scan: * Using the existing main branch, it recreates the `IllegalArgumentException: Unknown logical type: org.apache.hive.iceberg.org.apache.avro.LogicalTypes$TimestampMillis` issue * Using the [PR](https://github.com/apache/iceberg/pull/12397/files) changes resulted in that Exception no longer being thrown, but the wrong DateTime was being returned. * Both issues appeared to be fixed with these changes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
