nastra commented on code in PR #14456:
URL: https://github.com/apache/iceberg/pull/14456#discussion_r2485426114
##########
core/src/main/java/org/apache/iceberg/inmemory/InMemoryCatalog.java:
##########
@@ -217,6 +217,12 @@ public boolean dropNamespace(Namespace namespace) throws
NamespaceNotEmptyExcept
"Namespace %s is not empty. Contains %d table(s).", namespace,
tableIdentifiers.size());
}
+ List<TableIdentifier> viewIdentifiers = listViews(namespace);
+ if (!viewIdentifiers.isEmpty()) {
Review Comment:
An Iceberg namespace can only hold tables/views. Functions/Procedures would
only be relevant in the context of Spark and we have `SparkCatalog` that deals
with those things
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
