singhpk234 commented on code in PR #14456:
URL: https://github.com/apache/iceberg/pull/14456#discussion_r2482966976
##########
core/src/main/java/org/apache/iceberg/jdbc/JdbcCatalog.java:
##########
@@ -535,7 +535,15 @@ public boolean dropNamespace(Namespace namespace) throws
NamespaceNotEmptyExcept
List<TableIdentifier> tableIdentifiers = listTables(namespace);
if (tableIdentifiers != null && !tableIdentifiers.isEmpty()) {
throw new NamespaceNotEmptyException(
- "Namespace %s is not empty. %s tables exist.", namespace,
tableIdentifiers.size());
+ "Namespace %s is not empty. Contains %d table(s).", namespace,
tableIdentifiers.size());
+ }
+
+ if (schemaVersion == JdbcUtil.SchemaVersion.V1) {
Review Comment:
nit : wondering if we should add this check as
```suggestion
if (schemaVersion != JdbcUtil.SchemaVersion.V0) {
```
this will future proof this change for V2 too ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
