huaxingao commented on code in PR #14456:
URL: https://github.com/apache/iceberg/pull/14456#discussion_r2482092270
##########
core/src/main/java/org/apache/iceberg/jdbc/JdbcCatalog.java:
##########
@@ -538,6 +538,14 @@ public boolean dropNamespace(Namespace namespace) throws
NamespaceNotEmptyExcept
"Namespace %s is not empty. %s tables exist.", namespace,
tableIdentifiers.size());
}
+ if (schemaVersion == JdbcUtil.SchemaVersion.V1) {
+ List<TableIdentifier> viewIdentifiers = listViews(namespace);
+ if (viewIdentifiers != null && !viewIdentifiers.isEmpty()) {
+ throw new NamespaceNotEmptyException(
+ "Namespace %s is not empty. %s views exist.", namespace,
viewIdentifiers.size());
Review Comment:
nit: shall we align this with the previous error message `Namespace %s is
not empty. Contains %d view(s).`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
