danielcweeks commented on code in PR #14161:
URL: https://github.com/apache/iceberg/pull/14161#discussion_r2449085697
##########
aws/src/main/java/org/apache/iceberg/aws/s3/PrefixedS3Client.java:
##########
@@ -35,6 +36,8 @@ class PrefixedS3Client implements AutoCloseable {
private SerializableSupplier<S3AsyncClient> s3Async;
private transient volatile S3Client s3Client;
private transient volatile S3AsyncClient s3AsyncClient;
+ private transient String httpClientKey;
Review Comment:
I feel like we're exposing the whole registry and key far too broadly. It
feels like the registry shouldn't have to extend pasted the AwsClientFactories
where we're creating the S3 clients. Can't we push this all down so when a new
S3 client is created and the http client is registered/retrieved at that point?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
