amogh-jahagirdar commented on code in PR #14161:
URL: https://github.com/apache/iceberg/pull/14161#discussion_r2446355570
##########
aws/src/main/java/org/apache/iceberg/aws/s3/S3FileIOAwsClientFactory.java:
##########
@@ -44,4 +44,13 @@ public interface S3FileIOAwsClientFactory extends
Serializable {
* @param properties catalog properties
*/
void initialize(Map<String, String> properties);
+
+ /**
+ * Get the HTTP client key used for resource management.
+ *
+ * @return HTTP client key, or null if not available
+ */
+ default String httpClientKey() {
Review Comment:
I feel like it's a bit strange for S3FileIOClientFactory to have an
interface to get the httpClientKey. It puts the code in a bit of an awkward
spot where AwsClientFactory has to implement S3FileIOClientFactory, which is an
inversion of the heirarchy. Could we just introduce a mixin of some sort
`SupportsHttpClientTracking` which has this clientKey API?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
