amogh-jahagirdar commented on code in PR #14161:
URL: https://github.com/apache/iceberg/pull/14161#discussion_r2446392676
##########
aws/src/main/java/org/apache/iceberg/aws/s3/S3FileIOAwsClientFactory.java:
##########
@@ -44,4 +44,13 @@ public interface S3FileIOAwsClientFactory extends
Serializable {
* @param properties catalog properties
*/
void initialize(Map<String, String> properties);
+
+ /**
+ * Get the HTTP client key used for resource management.
+ *
+ * @return HTTP client key, or null if not available
+ */
+ default String httpClientKey() {
Review Comment:
It's worth thinking through if there's other reasonable ways to structure
this and store/supply the key state. If we had to do it similar to how it's
structured now, I think I'd still prefer some sort of
`SupportsHttpClientTracking` mixin which S3FileIOAwsClientFactory implements,
and then the AWsClientFacotry also independently extends this mixin.
That feels at least a little bit better than forcing AwsClientFactory to
extend S3FileIOAwsClientFactory which is backwards imo.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
