slfan1989 commented on code in PR #14243:
URL: https://github.com/apache/iceberg/pull/14243#discussion_r2445348680
##########
flink/v2.1/flink/src/main/java/org/apache/iceberg/flink/maintenance/api/ZkLockFactory.java:
##########
@@ -222,4 +252,28 @@ public void unlock() {
}
}
}
+
+ @VisibleForTesting
+ RetryPolicy createRetryPolicy(ZKRetryPolicies policy) {
Review Comment:
Thanks — agreed, the current method doesn’t need extra parameters since all
required values are already stored in the instance.
I’ll keep it as a non-static method that directly uses the existing
attributes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
