slfan1989 commented on code in PR #14243:
URL: https://github.com/apache/iceberg/pull/14243#discussion_r2445080522
##########
flink/v2.1/flink/src/main/java/org/apache/iceberg/flink/maintenance/api/ZkLockFactory.java:
##########
@@ -46,7 +46,7 @@ public class ZkLockFactory implements TriggerLockFactory {
private final int connectionTimeoutMs;
private final int baseSleepTimeMs;
private final int maxRetries;
- private final String retryPolicyName;
+ private volatile ZKRetryPolicies retryPolicy;
Review Comment:
`volatile` is unnecessary because `retryPolicy` is immutable after
construction.
There’s no concurrent modification or visibility issue, so `final` would be
more appropriate.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
