pvary commented on code in PR #14243:
URL: https://github.com/apache/iceberg/pull/14243#discussion_r2445497811
##########
flink/v2.1/flink/src/main/java/org/apache/iceberg/flink/maintenance/api/ZkLockFactory.java:
##########
@@ -55,14 +63,18 @@ public class ZkLockFactory implements TriggerLockFactory {
* @param connectionTimeoutMs Connection timeout in milliseconds
* @param baseSleepTimeMs Base sleep time in milliseconds
* @param maxRetries Maximum number of retries
+ * @param maxSleepTimeMs The maximum sleep time (ms) between retries.
+ * @param retryPolicy The retry policy enum defining the Curator retry
behavior.
*/
public ZkLockFactory(
String connectString,
String lockId,
int sessionTimeoutMs,
int connectionTimeoutMs,
int baseSleepTimeMs,
- int maxRetries) {
+ int maxRetries,
+ int maxSleepTimeMs,
+ ZKRetryPolicies retryPolicy) {
Review Comment:
not that important, but maybe follow the same order as the attributes, and
the value settings? 😄
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
