slfan1989 commented on code in PR #14243:
URL: https://github.com/apache/iceberg/pull/14243#discussion_r2444809084
##########
flink/v2.1/flink/src/main/java/org/apache/iceberg/flink/maintenance/api/LockConfig.java:
##########
@@ -202,6 +224,26 @@ public int zkMaxRetries() {
.parse();
}
+ /** Gets the Zookeeper maximum sleep time configuration (in milliseconds). */
+ public int zkMaxSleepMs() {
+ return confParser
+ .intConf()
+ .option(ZkLockConfig.ZK_MAX_SLEEP_MS_OPTION.key())
+ .flinkConfig(ZkLockConfig.ZK_MAX_SLEEP_MS_OPTION)
+ .defaultValue(ZkLockConfig.ZK_MAX_SLEEP_MS_OPTION.defaultValue())
+ .parse();
+ }
+
+ /** Gets the Zookeeper retry policy configuration. */
+ public String zkRetryPolicy() {
+ return confParser
+ .stringConf()
Review Comment:
Sure, that sounds good — I’ll update it to use enumConfParser.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
