pvary commented on code in PR #14243:
URL: https://github.com/apache/iceberg/pull/14243#discussion_r2435470360
##########
flink/v2.1/flink/src/main/java/org/apache/iceberg/flink/maintenance/api/ZkLockFactory.java:
##########
@@ -222,4 +240,36 @@ public void unlock() {
}
}
}
+
+ RetryPolicy createRetryPolicy() {
+
+ ZKRetryPolicies policy;
+ try {
+ policy = ZKRetryPolicies.valueOf(retryPolicyName);
Review Comment:
Could we check sooner that the config is valid?
We can have an enum as an input instead of the string
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
