nastra commented on code in PR #14291:
URL: https://github.com/apache/iceberg/pull/14291#discussion_r2428071303
##########
spark/v4.0/spark/src/main/java/org/apache/iceberg/spark/procedures/CreateChangelogViewProcedure.java:
##########
@@ -314,6 +308,21 @@ private static Column[] sortSpec(Dataset<Row> df, Column[]
repartitionSpec, bool
return sortSpec;
}
+ /**
+ * Retrieves the delimited column references for the given column names
+ *
+ * @param df dataframe to use for column references
+ * @param columnNames list of column names
+ * @return combined list of column references for the given 2 lists of
column names
+ */
+ private static Column[] getColumnReferences(Dataset<Row> df, String[]
columnNames) {
Review Comment:
nit: the codebase typically doesn't use `get` prefixes, so maybe rename this
to `fetchColumns` or `fetchColumnReferences`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
