nastra commented on code in PR #14291:
URL: https://github.com/apache/iceberg/pull/14291#discussion_r2420780025
##########
spark/v4.0/spark/src/main/java/org/apache/iceberg/spark/procedures/CreateChangelogViewProcedure.java:
##########
@@ -314,6 +310,18 @@ private static Column[] sortSpec(Dataset<Row> df, Column[]
repartitionSpec, bool
return sortSpec;
}
+ private static Column[] getColumns(Dataset<Row> df, String[] initialColumns,
String... addCols) {
Review Comment:
I feel like this method makes it actually more difficult to understand what
the code is doing. Also I'm not fully understanding what the second for loop is
doing?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
