danielcweeks commented on code in PR #14264:
URL: https://github.com/apache/iceberg/pull/14264#discussion_r2440610373
##########
core/src/main/java/org/apache/iceberg/BaseIncrementalChangelogScan.java:
##########
@@ -71,6 +80,12 @@ protected CloseableIterable<ChangelogScanTask> doPlanFiles(
.filter(manifest ->
changelogSnapshotIds.contains(manifest.snapshotId()))
.toSet();
+ // Build delete file index for existing deletes (before the start snapshot)
+ DeleteFileIndex existingDeleteIndex =
buildExistingDeleteIndex(fromSnapshotIdExclusive);
Review Comment:
I believe the only scenario where we need this is if there is an equality
delete in the incremental scan range. Can't we make this lazy so that we only
do this work in the event we encounter an equality delete as opposed to always
producing it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
