talatuyarer commented on code in PR #14264:
URL: https://github.com/apache/iceberg/pull/14264#discussion_r2418219303
##########
core/src/main/java/org/apache/iceberg/BaseIncrementalChangelogScan.java:
##########
@@ -71,6 +80,12 @@ protected CloseableIterable<ChangelogScanTask> doPlanFiles(
.filter(manifest ->
changelogSnapshotIds.contains(manifest.snapshotId()))
.toSet();
+ // Build delete file index for existing deletes (before the start snapshot)
+ DeleteFileIndex existingDeleteIndex =
buildExistingDeleteIndex(fromSnapshotIdExclusive);
Review Comment:
@pvary and @danielcweeks We need previous Delete indexes for `Overlapping
Equality + Position Deletes` scenario. Let says I deleted a row with positional
delete file (lets says there is a id column i delete id = 5) before my scan
range. In my scan range i delete all rows with equality delete ( lets assume I
deleted id > 1) We should not emit DELETE two times for id =5 row because it is
already deleted before my scan.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
