pvary commented on code in PR #14245:
URL: https://github.com/apache/iceberg/pull/14245#discussion_r2439479975
##########
flink/v2.1/flink/src/main/java/org/apache/iceberg/flink/data/FlinkValueWriters.java:
##########
@@ -139,9 +139,9 @@ private static class TimestampNanosWriter implements
ValueWriter<TimestampData>
@Override
public void write(TimestampData timestampData, Encoder encoder) throws
IOException {
- long nanos =
- timestampData.getMillisecond() * 1_000_000 +
timestampData.getNanoOfMillisecond();
- encoder.writeLong(nanos);
+ long value =
+ timestampData.getMillisecond() * 1_000_000L +
timestampData.getNanoOfMillisecond();
+ encoder.writeLong(value);
Review Comment:
Unneccessary change again
##########
flink/v2.1/flink/src/main/java/org/apache/iceberg/flink/data/FlinkValueWriters.java:
##########
@@ -139,9 +139,9 @@ private static class TimestampNanosWriter implements
ValueWriter<TimestampData>
@Override
public void write(TimestampData timestampData, Encoder encoder) throws
IOException {
- long nanos =
- timestampData.getMillisecond() * 1_000_000 +
timestampData.getNanoOfMillisecond();
- encoder.writeLong(nanos);
+ long value =
+ timestampData.getMillisecond() * 1_000_000L +
timestampData.getNanoOfMillisecond();
+ encoder.writeLong(value);
Review Comment:
Unnecessary change again
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
