pvary commented on code in PR #14245:
URL: https://github.com/apache/iceberg/pull/14245#discussion_r2414547146
##########
flink/v2.1/flink/src/main/java/org/apache/iceberg/flink/FlinkTypeToType.java:
##########
@@ -137,12 +137,30 @@ public Type visit(TimeType timeType) {
@Override
public Type visit(TimestampType timestampType) {
- return Types.TimestampType.withoutZone();
+ int precision = timestampType.getPrecision();
+ if (precision > 9) {
+ throw new IllegalArgumentException(
+ "Unsupported timestamp precision: " + precision + ". Maximum
supported precision is 9.");
+ }
+ if (precision == 9) {
+ return Types.TimestampNanoType.withoutZone();
+ } else {
Review Comment:
Are precision 7, 8 are valid values?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
