Guosmilesmile commented on code in PR #14197:
URL: https://github.com/apache/iceberg/pull/14197#discussion_r2384186610
##########
flink/v2.1/flink/src/main/java/org/apache/iceberg/flink/sink/dynamic/DynamicWriteResultAggregator.java:
##########
@@ -167,7 +167,8 @@ byte[] writeToManifest(
FlinkManifestUtil.writeCompletedFiles(
result,
() -> outputFileFactory(key.tableName()).create(checkpointId),
- spec(key.tableName(), key.specId()));
+ spec(key.tableName(), key.specId()),
+ 2);
Review Comment:
If upsert mode is used for v3 tables, an error will occur when obtaining
`deleteBytes` in `CommitSummary` due to the lack of information from v2
serialization.
The dynamic sink might write to both v2 and v3 tables simultaneously. The
`WriteTarget` needs to add the table type to obtain DeltaManifests for
different versions. Currently, it uses v2 version by default.
If we change `WriteTarget`, it will involve modifications to serialization,
which could be quite extensive. Is there any better suggestion for this part?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
