pvary commented on code in PR #12298:
URL: https://github.com/apache/iceberg/pull/12298#discussion_r2382318081
##########
parquet/src/main/java/org/apache/iceberg/parquet/Parquet.java:
##########
@@ -136,6 +138,15 @@ private Parquet() {}
"parquet.read.support.class",
"parquet.crypto.factory.class");
+ private static final int MAX_RECORDS_PER_BATCH_DEFAULT = 10000;
+
+ public static final String WRITER_VERSION_KEY = "parquet.writer.version";
+
+ /**
+ * @deprecated Since 1.10.0, will be removed in 1.11.0. Use {@link
+ * FormatModelRegistry#writeBuilder(FileFormat, Class,
EncryptedOutputFile)} instead.
+ */
+ @Deprecated
Review Comment:
Added as an open question to the doc/discussion. See:
https://docs.google.com/document/d/1sF_d4tFxJsZWsZFCyCL9ZE7YuI7-P3VrzMLIrrTIxds/edit?pli=1&tab=t.0#heading=h.n4pazjga6reo
I would prefer not, but let's hear what the community thinks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
