pvary commented on code in PR #12298:
URL: https://github.com/apache/iceberg/pull/12298#discussion_r2382465891
##########
data/src/test/java/org/apache/iceberg/io/TestAppenderFactory.java:
##########
@@ -259,6 +260,7 @@ public void testPosDeleteWriter() throws IOException {
.isEqualTo(expectedRowSet(expected));
}
+ @Disabled("Deprecated API")
Review Comment:
We still need to provide functionality in 1.11.0, as the deprecation will
only happen in that release.
So unless we decide to make an exception, we should keep the old
functionality and the test for that.
Most probably the correct way would be to keep this test in
GenericAppenderFactory, but we can disable it in the Flink and in the Spark
Appender
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
