pvary commented on code in PR #12298:
URL: https://github.com/apache/iceberg/pull/12298#discussion_r2382319167
##########
parquet/src/main/java/org/apache/iceberg/parquet/Parquet.java:
##########
@@ -260,21 +269,147 @@ public WriteBuilder overwrite() {
}
public WriteBuilder overwrite(boolean enabled) {
- this.writeMode = enabled ? ParquetFileWriter.Mode.OVERWRITE :
ParquetFileWriter.Mode.CREATE;
+ impl.writeMode = enabled ? ParquetFileWriter.Mode.OVERWRITE :
ParquetFileWriter.Mode.CREATE;
return this;
}
public WriteBuilder writerVersion(WriterVersion version) {
- this.writerVersion = version;
+ impl.set(WRITER_VERSION_KEY, version.name());
return this;
}
public WriteBuilder withFileEncryptionKey(ByteBuffer encryptionKey) {
- this.fileEncryptionKey = encryptionKey;
+ impl.fileEncryptionKey(encryptionKey);
return this;
}
public WriteBuilder withAADPrefix(ByteBuffer aadPrefix) {
+ impl.fileAADPrefix(aadPrefix);
+ return this;
+ }
+
+ /*
+ * Sets the writer version. Default value is PARQUET_1_0 (v1).
+ */
+ @VisibleForTesting
+ WriteBuilder withWriterVersion(WriterVersion version) {
Review Comment:
Nope. This is exsiting
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
