Kontinuation commented on code in PR #12667:
URL: https://github.com/apache/iceberg/pull/12667#discussion_r2371533327
##########
api/src/main/java/org/apache/iceberg/types/Types.java:
##########
@@ -81,7 +81,6 @@ public static Type fromTypeName(String typeString) {
Matcher geometry = GEOMETRY_PARAMETERS.matcher(typeString);
if (geometry.matches()) {
String crs = geometry.group(1);
- Preconditions.checkArgument(!crs.contains(","), "Invalid CRS: %s", crs);
Review Comment:
`,` in CRS of geometry types won't introduce ambiguity, so we decided to
keep it as-is. See
https://github.com/apache/iceberg/pull/12346#discussion_r2013049486
##########
api/src/main/java/org/apache/iceberg/types/Types.java:
##########
@@ -81,7 +81,6 @@ public static Type fromTypeName(String typeString) {
Matcher geometry = GEOMETRY_PARAMETERS.matcher(typeString);
if (geometry.matches()) {
String crs = geometry.group(1);
- Preconditions.checkArgument(!crs.contains(","), "Invalid CRS: %s", crs);
Review Comment:
`,` in CRS of geometry types won't introduce ambiguity, so we decided to
keep it as is. See
https://github.com/apache/iceberg/pull/12346#discussion_r2013049486
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
