stevenzwu commented on code in PR #12667:
URL: https://github.com/apache/iceberg/pull/12667#discussion_r2369340938
##########
api/src/main/java/org/apache/iceberg/types/Types.java:
##########
@@ -599,7 +598,7 @@ public TypeID typeId() {
}
public String crs() {
- return crs;
+ return crs != null ? crs : DEFAULT_CRS;
Review Comment:
ok. we want to allow crs null so that `toString` display differently for
null value. I am fine with that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
