ForeverAngry commented on code in PR #2431: URL: https://github.com/apache/iceberg-python/pull/2431#discussion_r2368953858
########## tests/table/test_manage_snapshots.py: ########## @@ -0,0 +1,365 @@ +# Licensed to the Apache Software Foundation (ASF) under one Review Comment: That's a good catch. I didn't think to test the test on the original code to make sure they failed, before writing and running them on the bug fix. I probably shield have taken a TDD approach on this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
