Fokko commented on code in PR #2431:
URL: https://github.com/apache/iceberg-python/pull/2431#discussion_r2368914507
##########
tests/table/test_manage_snapshots.py:
##########
@@ -0,0 +1,365 @@
+# Licensed to the Apache Software Foundation (ASF) under one
Review Comment:
When I check out your branch, and revert the changes:
```
--- a/pyiceberg/table/update/snapshot.py
+++ b/pyiceberg/table/update/snapshot.py
@@ -810,13 +810,11 @@ class
ManageSnapshots(UpdateTableMetadata["ManageSnapshots"]):
ms.create_tag(snapshot_id1, "Tag_A").create_tag(snapshot_id2,
"Tag_B")
"""
- _updates: Tuple[TableUpdate, ...]
- _requirements: Tuple[TableRequirement, ...]
+ _updates: Tuple[TableUpdate, ...] = ()
+ _requirements: Tuple[TableRequirement, ...] = ()
def __init__(self, transaction: Transaction) -> None:
super().__init__(transaction)
- self._updates = ()
- self._requirements = ()
def _commit(self) -> UpdatesAndRequirements:
"""Apply the pending changes and commit."""
```
While running the tests, everything still passes:
```
============================= test session starts
==============================
collecting ... collected 5 items
tests/table/test_manage_snapshots.py::test_manage_snapshots_thread_safety_fix
PASSED [ 20%]
tests/table/test_manage_snapshots.py::test_manage_snapshots_concurrent_operations
PASSED [ 40%]
tests/table/test_manage_snapshots.py::test_manage_snapshots_concurrent_different_tables
PASSED [ 60%]
tests/table/test_manage_snapshots.py::test_manage_snapshots_cross_table_isolation
PASSED [ 80%]
tests/table/test_manage_snapshots.py::test_manage_snapshots_concurrent_same_table_different_operations
PASSED [100%]
============================== 5 passed in 0.05s
===============================
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
