Fokko commented on code in PR #2431: URL: https://github.com/apache/iceberg-python/pull/2431#discussion_r2369020332
########## tests/table/test_manage_snapshots.py: ########## @@ -0,0 +1,365 @@ +# Licensed to the Apache Software Foundation (ASF) under one Review Comment: Since we have built up quite a collection of tests over the years, they take longer and longer to run. So we want to make sure that they address underlying issues. I think we can drop the tests for this change. I don't think this class is subject to the thread-safe issue because it uses `tuples` rather than mutable collections like `set` and `list`. However, it is important to follow the best practice of setting the fields in the constructor. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
