RussellSpitzer commented on code in PR #14081:
URL: https://github.com/apache/iceberg/pull/14081#discussion_r2349231348


##########
parquet/src/main/java/org/apache/iceberg/parquet/ParquetMetricsRowGroupFilter.java:
##########
@@ -157,8 +157,10 @@ public <T> Boolean notNull(BoundReference<T> ref) {
 
       // When filtering nested types notNull() is implicit filter passed even 
though complex
       // filters aren't pushed down in Parquet. Leave all nested column type 
filters to be
-      // evaluated post scan.
-      if (schema.findType(id) instanceof Type.NestedType) {
+      // evaluated post scan. Variant types also need to be evaluated post 
scan to access
+      // shredded statistics.
+      Type type = schema.findType(id);
+      if (type instanceof Type.NestedType || type.isVariantType()) {

Review Comment:
   +1



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to