geruh commented on code in PR #14081:
URL: https://github.com/apache/iceberg/pull/14081#discussion_r2361396358
##########
spark/v4.0/spark/src/test/java/org/apache/iceberg/spark/sql/TestFilterPushDown.java:
##########
@@ -600,7 +654,7 @@ private void checkFilters(
if (sparkFilter != null) {
assertThat(planAsString)
.as("Post scan filter should match")
- .contains("Filter (" + sparkFilter + ")");
+ .containsAnyOf("Filter (" + sparkFilter + ")", "Filter " +
sparkFilter);
Review Comment:
No this is specific to the spark filters. I added this so we can capture a
simple spark filter. e.g. when spark doesn't apply a `NOT NULL` check to a
filter. This is observed with `IN` predicates where Spark doesn't add the
implicit `IS NOT NULL` check, resulting in simpler filter expressions without
parentheses.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
