RussellSpitzer commented on code in PR #14040:
URL: https://github.com/apache/iceberg/pull/14040#discussion_r2356652587
##########
parquet/src/main/java/org/apache/iceberg/parquet/ParquetValueReaders.java:
##########
@@ -189,6 +191,16 @@ public static ParquetValueReader<Long>
int96Timestamps(ColumnDescriptor desc) {
return new TimestampInt96Reader(desc);
}
+ @SuppressWarnings("unchecked")
+ public static <T extends StructLike> ParquetValueReader<T> structLikeReader(
+ List<ParquetValueReader<?>> readers, Types.StructType struct, Class<T>
structClass) {
+ if (structClass.equals(Record.class)) {
Review Comment:
Yeah I thought about this as well, I didn't want to break that since someone
had spent the time to add in the comment.
##########
parquet/src/main/java/org/apache/iceberg/parquet/ParquetValueReaders.java:
##########
@@ -189,6 +191,16 @@ public static ParquetValueReader<Long>
int96Timestamps(ColumnDescriptor desc) {
return new TimestampInt96Reader(desc);
}
+ @SuppressWarnings("unchecked")
+ public static <T extends StructLike> ParquetValueReader<T> structLikeReader(
+ List<ParquetValueReader<?>> readers, Types.StructType struct, Class<T>
structClass) {
+ if (structClass.equals(Record.class)) {
Review Comment:
Yeah I thought about this as well, I didn't want to remove the interface
since someone had spent the time to add in the comment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
