pvary commented on code in PR #14040:
URL: https://github.com/apache/iceberg/pull/14040#discussion_r2359548074
##########
parquet/src/main/java/org/apache/iceberg/parquet/Parquet.java:
##########
@@ -1220,35 +1274,43 @@ public ReadBuilder createReaderFunc(
this.batchedReaderFunc == null,
"Cannot set reader function: batched reader function already set");
Preconditions.checkArgument(
- this.readerFuncWithSchema == null,
- "Cannot set reader function: 2-argument reader function already
set");
- this.readerFunc = newReaderFunction;
+ this.readerFunction == null, "Cannot set reader function: reader
function already set");
+ this.readerFunction = new UnaryReaderFunction(newReaderFunction);
return this;
}
public ReadBuilder createReaderFunc(
BiFunction<Schema, MessageType, ParquetValueReader<?>>
newReaderFunction) {
- Preconditions.checkArgument(
- this.readerFunc == null,
- "Cannot set 2-argument reader function: reader function already
set");
Preconditions.checkArgument(
this.batchedReaderFunc == null,
- "Cannot set 2-argument reader function: batched reader function
already set");
- this.readerFuncWithSchema = newReaderFunction;
+ "Cannot set reader function: batched reader function already set");
+ Preconditions.checkArgument(
+ this.readerFunction == null, "Cannot set reader function: reader
function already set");
+ this.readerFunction = new BinaryReaderFunction(newReaderFunction);
return this;
}
public ReadBuilder createBatchedReaderFunc(Function<MessageType,
VectorizedReader<?>> func) {
Preconditions.checkArgument(
- this.readerFunc == null,
- "Cannot set batched reader function: reader function already set");
+ this.batchedReaderFunc == null,
+ "Cannot set batched reader function: batched reader function already
set");
Preconditions.checkArgument(
- this.readerFuncWithSchema == null,
- "Cannot set batched reader function: 2-argument reader function
already set");
+ this.readerFunction == null,
+ "Cannot set batched reader function: ReaderFunction already set");
this.batchedReaderFunc = func;
return this;
}
+ public ReadBuilder createReaderFunc(ReaderFunction reader) {
Review Comment:
Shall we deprecate the other reader function methods?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
