RussellSpitzer commented on code in PR #14040:
URL: https://github.com/apache/iceberg/pull/14040#discussion_r2356628434
##########
parquet/src/main/java/org/apache/iceberg/data/parquet/InternalReader.java:
##########
@@ -72,4 +91,12 @@ protected ParquetValueReader<?> timeReader(ColumnDescriptor
desc) {
protected ParquetValueReader<?> timestampReader(ColumnDescriptor desc,
boolean isAdjustedToUTC) {
return ParquetValueReaders.timestamps(desc);
}
+
+ public void setCustomType(int fieldId, Class<? extends StructLike> type) {
+ this.typesById.put(fieldId, type);
+ }
+
+ public void setRootType(Class<? extends StructLike> rootClass) {
+ setCustomType(ROOT_ID, rootClass);
Review Comment:
Removed do to other refactors
##########
parquet/src/main/java/org/apache/iceberg/data/parquet/InternalReader.java:
##########
@@ -72,4 +91,12 @@ protected ParquetValueReader<?> timeReader(ColumnDescriptor
desc) {
protected ParquetValueReader<?> timestampReader(ColumnDescriptor desc,
boolean isAdjustedToUTC) {
return ParquetValueReaders.timestamps(desc);
}
+
+ public void setCustomType(int fieldId, Class<? extends StructLike> type) {
+ this.typesById.put(fieldId, type);
+ }
+
+ public void setRootType(Class<? extends StructLike> rootClass) {
+ setCustomType(ROOT_ID, rootClass);
Review Comment:
Removed due to other refactors
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]