stevenzwu commented on code in PR #13714:
URL: https://github.com/apache/iceberg/pull/13714#discussion_r2353588954
##########
flink/v2.1/flink/src/main/java/org/apache/iceberg/flink/sink/IcebergWriteAggregator.java:
##########
@@ -76,11 +85,21 @@ public void open() throws Exception {
@Override
public void finish() throws IOException {
- prepareSnapshotPreBarrier(Long.MAX_VALUE);
+ prepareSnapshotPreBarrier(lastCheckpointId + 1);
}
@Override
public void prepareSnapshotPreBarrier(long checkpointId) throws IOException {
+ if (checkpointId == lastCheckpointId) {
Review Comment:
I am also wondering if there can be `WriteResult` processed by the
`IcebergWriteAggregator` btw the `finish` and `prepareSnapshotPreBarrier`
calls. e.g.
E.g. here is a timeline for the aggregator operator
- T1: `prepareSnapshotPreBarrier(N)` completed
- T2: processed some `WriteResult` from writer tasks
- T3: `finish()` method is called
- T4: processed more `WriteResult` from writer tasks
- T5: `prepareSnapshotPreBarrier(N+1)` method is called
Can the above sequence happen? if yes, write results from T4 will be lost.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
