stevenzwu commented on code in PR #13714: URL: https://github.com/apache/iceberg/pull/13714#discussion_r2349789616
########## flink/v2.1/flink/src/main/java/org/apache/iceberg/flink/sink/IcebergWriteAggregator.java: ########## @@ -49,12 +50,20 @@ class IcebergWriteAggregator extends AbstractStreamOperator<CommittableMessage<I private transient ManifestOutputFileFactory icebergManifestOutputFileFactory; private transient Table table; private final TableLoader tableLoader; + private long lastCheckpointId; Review Comment: nit: initialize it to `CheckpointIDCounter.INITIAL_CHECKPOINT_ID - 1`. it is essentially the same value `0`. but it will be more clear to readers. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
