stevenzwu commented on code in PR #13714:
URL: https://github.com/apache/iceberg/pull/13714#discussion_r2349310861
##########
flink/v2.1/flink/src/main/java/org/apache/iceberg/flink/sink/IcebergWriteAggregator.java:
##########
@@ -76,11 +85,21 @@ public void open() throws Exception {
@Override
public void finish() throws IOException {
- prepareSnapshotPreBarrier(Long.MAX_VALUE);
+ prepareSnapshotPreBarrier(lastCheckpointId + 1);
}
@Override
public void prepareSnapshotPreBarrier(long checkpointId) throws IOException {
+ if (checkpointId == lastCheckpointId) {
Review Comment:
sorry, there is a typo in my previous comment. I meant `finish` method was
added mainly for the batch execution. I am wondering if we can call
`prepareSnapshotPreBarrier (Long.MAX_VALUE)` in the `finish` method only for
batch execution. For streaming execution, it is not necessarily to flush in the
finish method. Streaming execution only flushes during checkpoint
`prepareSnapshotPreBarrier`.
> Showing checkpoint id 1 might surprise users who normally saw
Long.MAX_VALUE, but I don't see a big issue with that, since it reflects what's
actually happening in Flink.
It's a behavior change. we will need to at least call out in the release
note.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
