WillAyd commented on code in PR #233: URL: https://github.com/apache/iceberg-cpp/pull/233#discussion_r2353315691
########## CMakeLists.txt: ########## @@ -60,7 +60,6 @@ include(CMakeParseArguments) include(IcebergBuildUtils) include(IcebergSanitizer) include(IcebergThirdpartyToolchain) -include(GenerateExportHeader) Review Comment: ~It also appears that this was being used incorrectly, as shared library builds on Windows are broken on main (they aren't tested in the CMake CI)~ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
