WillAyd commented on code in PR #233:
URL: https://github.com/apache/iceberg-cpp/pull/233#discussion_r2352773334
##########
.github/workflows/test.yml:
##########
@@ -96,3 +96,53 @@ jobs:
run: |
call "C:\Program Files\Microsoft Visual
Studio\2022\Enterprise\VC\Auxiliary\Build\vcvarsall.bat" x64
bash -c "ci/scripts/build_example.sh $(pwd)/example"
+ ubuntu-meson:
+ name: Meson - AMD64 Ubuntu 24.04
+ runs-on: ubuntu-24.04
+ timeout-minutes: 30
+ strategy:
+ fail-fast: false
+ steps:
+ - uses: actions/setup-python@v5
+ with:
+ python-version: '3.x'
+ - name: Checkout iceberg-cpp
+ uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 #
v5.0.0
+ with:
+ fetch-depth: 0
+ - name: Install build dependencies
+ run: |
+ python3 -m pip install --upgrade pip
+ python3 -m pip install meson ninja
+ - name: Build Iceberg
Review Comment:
These CI jobs just invoke Meson directly, as I think the steps are pretty
straightforward. However, some of the other Apache projects choose to still put
this all into the `ci/build_xxx.sh` script - happy to migrate there if
preferable
##########
.github/workflows/test.yml:
##########
@@ -96,3 +96,53 @@ jobs:
run: |
call "C:\Program Files\Microsoft Visual
Studio\2022\Enterprise\VC\Auxiliary\Build\vcvarsall.bat" x64
bash -c "ci/scripts/build_example.sh $(pwd)/example"
+ ubuntu-meson:
Review Comment:
I'm happy to try and create a matrix of these jobs as required. There
weren't any matrix jobs today so I didn't want to introduce that here. Can do
as a follow up or here if desired
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
