WillAyd commented on code in PR #233:
URL: https://github.com/apache/iceberg-cpp/pull/233#discussion_r2389545300
##########
src/iceberg/json_internal.h:
##########
@@ -38,7 +38,7 @@ namespace iceberg {
///
/// \param sort_field The `SortField` object to be serialized.
/// \return A JSON object representing the `SortField` in the form of
key-value pairs.
-nlohmann::json ToJson(const SortField& sort_field);
+ICEBERG_EXPORT nlohmann::json ToJson(const SortField& sort_field);
Review Comment:
After further examination some of these are required because they are used
in the test suite that links back to the iceberg library. If we wanted to scale
this back, I can go through and only export the symbols that are required for
the tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
