badalprasadsingh commented on code in PR #524:
URL: https://github.com/apache/iceberg-go/pull/524#discussion_r2324002996
##########
table/internal/utils.go:
##########
@@ -212,8 +214,7 @@ func (d *DataFileStatistics) PartitionValue(field
iceberg.PartitionField, sc *ic
}
if !field.Transform.PreservesOrder() {
- panic(fmt.Errorf("cannot infer partition value from parquet
metadata for a non-linear partition field: %s with transform %s",
- field.Name, field.Transform))
+ return nil
Review Comment:
From the `partitioned-fanout-writer` side I pass back the partition values
for all transformations. So in case it encounters a `non-linear`
transformation, it can use the partition value from the writer side for each
`datafile`, no need for it to calculate.
However in case of `AddFiles()` func which ultimately calls the
`filesToDataFiles` func, we still throw an `error` for non-linear
transformations
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
