badalprasadsingh commented on code in PR #524:
URL: https://github.com/apache/iceberg-go/pull/524#discussion_r2323941458
##########
table/arrow_utils.go:
##########
@@ -1030,11 +1031,19 @@ func (sc *schemaCompatVisitor) isFieldCompat(lhs
iceberg.NestedField) bool {
func (sc *schemaCompatVisitor) Schema(s *iceberg.Schema, v func() bool) bool {
if !v() {
- pterm.DisableColor()
- tbl :=
pterm.DefaultTable.WithHasHeader(true).WithData(sc.errorData)
- tbl.Render()
- txt, _ := tbl.Srender()
- pterm.EnableColor()
+ var lines []string
+ lines = append(lines, " | Table Field |
Requested Field")
+
+ for i, row := range sc.errorData {
+ if i == 0 {
+ continue
+ }
+ if len(row) >= 3 {
+ lines = append(lines, fmt.Sprintf("%s | %-24s |
%s", row[0], row[1], row[2]))
+ }
+ }
Review Comment:
This change fixes the formatting mismatch for `TestTableWriting` test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
