badalprasadsingh commented on code in PR #524:
URL: https://github.com/apache/iceberg-go/pull/524#discussion_r2313053251
##########
manifest.go:
##########
@@ -37,6 +37,19 @@ import (
"github.com/hamba/avro/v2/ocf"
)
+func init() {
+ avro.Register("fixed", [1]byte{})
+ avro.Register("fixed", [2]byte{})
+ avro.Register("fixed", [3]byte{})
+ avro.Register("fixed", [4]byte{})
+ avro.Register("fixed", [5]byte{})
+ avro.Register("fixed", [6]byte{})
+ avro.Register("fixed", [7]byte{})
+ avro.Register("fixed", [8]byte{})
+ avro.Register("fixed", [16]byte{})
Review Comment:
These are required so that `Avro` logical type names to Go concrete types
for `serialization/deserialization`.
Without registration, the Avro library doesn't know how to handle custom
logical types. Enables proper `encoding/decoding` of Iceberg-specific data
types in manifest files
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
