Fokko commented on code in PR #13445:
URL: https://github.com/apache/iceberg/pull/13445#discussion_r2298924953
##########
spark/v4.0/spark/src/main/java/org/apache/iceberg/spark/data/SparkParquetWriters.java:
##########
@@ -96,14 +98,18 @@ public ParquetValueWriter<?> message(
public ParquetValueWriter<?> struct(
StructType sStruct, GroupType struct, List<ParquetValueWriter<?>>
fieldWriters) {
List<Type> fields = struct.getFields();
- StructField[] sparkFields = sStruct.fields();
List<ParquetValueWriter<?>> writers =
Lists.newArrayListWithExpectedSize(fieldWriters.size());
- List<DataType> sparkTypes = Lists.newArrayList();
for (int i = 0; i < fields.size(); i += 1) {
writers.add(newOption(struct.getType(i), fieldWriters.get(i)));
- sparkTypes.add(sparkFields[i].dataType());
}
- return new InternalRowWriter(writers, sparkTypes);
+
+ StructField[] sFields = sStruct.fields();
Review Comment:
Sure thing. I prefer the stream API, but I thought sticking with the loops
to maintain consistency.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
