stevenzwu commented on code in PR #13445:
URL: https://github.com/apache/iceberg/pull/13445#discussion_r2299240111
##########
spark/v4.0/spark/src/main/java/org/apache/iceberg/spark/data/ParquetWithSparkSchemaVisitor.java:
##########
@@ -182,18 +183,15 @@ private static <T> T visitField(
private static <T> List<T> visitFields(
StructType struct, GroupType group, ParquetWithSparkSchemaVisitor<T>
visitor) {
- StructField[] sFields = struct.fields();
- Preconditions.checkArgument(
- sFields.length == group.getFieldCount(), "Structs do not match: %s and
%s", struct, group);
List<T> results =
Lists.newArrayListWithExpectedSize(group.getFieldCount());
- for (int i = 0; i < sFields.length; i += 1) {
- Type field = group.getFields().get(i);
- StructField sField = sFields[i];
- Preconditions.checkArgument(
-
field.getName().equals(AvroSchemaUtil.makeCompatibleName(sField.name())),
- "Structs do not match: field %s != %s",
- field.getName(),
- sField.name());
+ for (StructField sField : struct.fields()) {
+ final int idx;
+ try {
Review Comment:
we should avoid more expensive try-catch for normal condition of
null/unknown type. I was thinking about a if check like this.
```
for (StructField sField : struct.fields()) {
// skip null types since they don't exist in Parquet
if (sField.dataType() != DataTypes.NullType) {
int index =
group.getFieldIndex(AvroSchemaUtil.makeCompatibleName(sField.name()));
Type field = group.getType(index);
results.add(visitField(sField, field, visitor));
}
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
