kevinjqliu commented on code in PR #13445:
URL: https://github.com/apache/iceberg/pull/13445#discussion_r2296798056


##########
spark/v4.0/spark/src/main/java/org/apache/iceberg/spark/SparkSchemaUtil.java:
##########
@@ -93,7 +93,7 @@ public static PartitionSpec specForTable(SparkSession spark, 
String name)
    * @throws IllegalArgumentException if the type cannot be converted to Spark
    */
   public static StructType convert(Schema schema) {
-    return (StructType) TypeUtil.visit(schema, new TypeToSparkType());
+    return convert(schema);

Review Comment:
   this will cause stack overflow? 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to