RussellSpitzer commented on code in PR #13785:
URL: https://github.com/apache/iceberg/pull/13785#discussion_r2277890348
##########
core/src/main/java/org/apache/iceberg/MetricsConfig.java:
##########
@@ -146,7 +146,7 @@ public Set<Integer> struct(Types.StructType struct,
Iterable<Set<Integer>> field
// visit children to add more ids
Iterator<Set<Integer>> iter = fieldResults.iterator();
- while (shouldContinue() && iter.hasNext()) {
+ while (iter.hasNext()) {
iter.next();
Review Comment:
I'm very confused about this, what does iter.next() do here? This looks like
a noop? (although I didn't understand what it was doing before either
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
