dramaticlly commented on code in PR #13785:
URL: https://github.com/apache/iceberg/pull/13785#discussion_r2268593806
##########
core/src/main/java/org/apache/iceberg/MetricsConfig.java:
##########
@@ -146,7 +146,7 @@ public Set<Integer> struct(Types.StructType struct,
Iterable<Set<Integer>> field
// visit children to add more ids
Iterator<Set<Integer>> iter = fieldResults.iterator();
- while (shouldContinue() && iter.hasNext()) {
Review Comment:
I am trying to address the comment from @rdblue from
https://github.com/apache/iceberg/pull/13039#discussion_r2254733603. I think he
is suggesting it's ok to visit inside the nested field instead of checking
before visit.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
